modify the sync numbers of 'start_sync' function #5869
Conversation
|
What is the cause of the problem that 'Some checks were not successful |
There was a problem hiding this comment.
For the next person who reviews, please note that non-adversarial input when both known_blocks and known_trx mode == last_irr_catchup should also have the peer's LIB number in known_trx.pending and the peer's head block number in known_blocks.pending . This makes the target of the sync the peer's LIB which is "correct"
|
1.3.x? |
|
@spoonincode @wanderingbort and I discussed 1.3.x for this. It is a bit obscure. I'm good with either 1.3.x or develop. Thoughts? |
|
I didn't actually study the change closely. If you & bart already think it's obscure enough to wait for 1.4 I've got no beef -- just wanted to make sure we considered it |
if the 'known_trx.mode' of the 'notice_message' is 'last_irr_catch_up', should use 'known_trx.pending' instead of 'known_blocks_pending'. because the blocks of 'known_blocks_pending' needs to be verified.